Remove plugin/path/backend variables from pants_from_sources script.
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
added a commit
to pantsbuild/example-codegen
that referenced
this pull request
Feb 4, 2022
The main change is switching to the new `[python].enable_resolves`, which allows us to have Pants generate the lockfile for us and use `--hash`! This also applies pantsbuild/example-python#90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone wanted to override any of these, they could do so via environment variables. But I've never seen it be necessary to actually commit an edit, because when testing with a wildly different version of Pants, it's usually a temporary measure.