Skip to content

Fix the README examples, and upgrade to a non-busted Pants. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2022
Merged

Fix the README examples, and upgrade to a non-busted Pants. #97

merged 1 commit into from
Mar 22, 2022

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Mar 22, 2022

Fixes #96

@benjyw benjyw requested review from Eric-Arellano and kaos March 22, 2022 17:02
@benjyw
Copy link
Contributor Author

benjyw commented Mar 22, 2022

I thought we had CI set up for this. We should probably get that going, and run all the README commands in it...

@stuhood
Copy link
Member

stuhood commented Mar 22, 2022

We do: not sure why it didn't kick off in a more timely matter, but it seems to be running now.

kaos
kaos approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊

@benjyw benjyw merged commit 2062fd9 into pantsbuild:main Mar 22, 2022
@benjyw benjyw deleted the fix_readme branch March 22, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@kaos kaos kaos approved these changes

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README.md examples out of date with the source?
3 participants
@benjyw @stuhood @kaos