Skip to content

Conversation

TonySherman
Copy link
Contributor

This adds some more complete code examples and usage of various pants goals

@benjyw benjyw requested review from huonw and kaos May 16, 2024 21:52
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Thanks for the great examples.

The lambda context fixture could be shared between the tests in a conftest.py test util file, but that's minor.

@TonySherman
Copy link
Contributor Author

lgtm! Thanks for the great examples.

The lambda context fixture could be shared between the tests in a conftest.py test util file, but that's minor.

I went ahead and added this now. Thanks for the review!

@kaos kaos merged commit 797c6e1 into pantsbuild:main May 20, 2024
@TonySherman TonySherman deleted the example_api_code_updates branch May 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants