[internal] House development venvs in home. #11616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bottom commit is the actual change: the top commit is the ripple effects. |
Eric-Arellano
approved these changes
Mar 1, 2021
jsirois
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
A few more:
$ git grep build-support .github/ | grep virtual
.github/workflows/test.yaml: build-support/virtualenvs
.github/workflows/test.yaml: build-support/virtualenvs
.github/workflows/test.yaml: build-support/virtualenvs
.github/workflows/test.yaml: build-support/virtualenvs
.github/workflows/test.yaml: build-support/virtualenvs
tdyas
approved these changes
Mar 1, 2021
stuhood
force-pushed
the
stuhood/venvs-in-home
branch
from
0002b52
to
1b4e269
Compare
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
…fetching from the cache. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/venvs-in-home
branch
from
a3ece2b
to
2f056c5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The venv for Pants' development dependencies currently lives in the working copy. This means that we need to gitignore it, but it also causes some trouble in the presence of virtualbox/vagrant mounts of the working copy, where it triggers hashicorp/vagrant#12057.
Solution
Move the virtualenvs directory into
$HOME.[ci skip-build-wheels]