Ivy rework #1321
Closed
Ivy rework #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android has 3 different concepts of android_library: .jars, .aars and source files. This first step only expressly supports from jars. Support for source libraries should be a fairly easy followup. .aars are TODO. This includes several separate example projects that will probably not need to be merged into Pants itself. The best thing would be for me to write a couple new Hello-Pants sample apps strictly for Pants, but time is short. The are all Apache or MIT licensed code and the LICENSES are included, so whatever works. There are two new local ivy resolvers. One is to interact with the local Android SDK as set by env ANDROID_HOME. The second is for jars I have checked-in to 3rdParty. The 3rdParty checking jars should be able to go away whenever someone gets a chance to add .aar support. The ivysettings for the local Android SDK is currently unused, because fetching jars violates the new classpath rules. I am including it here because it probably is the way we will want to interact with the SDK so I wanted to hear some thioughts as to a good solution. The Android BUILD file format needs a reimagining after library support goes in as well. Some of the things the BUILD file requires could be easily reduced to sensible defaults. A TODO as well. Compiling any of the included examples worka but you have to pass compile.checkstyle --skip for a couple of them.
|
Abandoned in favor of #1377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused Android SDK resolver for now.
This is something that Pants will have at one point, but the
CI is choking so lets see whats up.