More accurate reported runtime when pantsd is in use
#14177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o capture the startup time of the server. [ci skip-rust] [ci skip-build-wheels]
asherf
approved these changes
Jan 14, 2022
Eric-Arellano
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PantsLoadercaptures astart_timeas early as possible, which is then supposed to be propagated all the way to thepantsdserver via environment variables. But theRemotePantsRunnerwas calculating its own start time, which would miss out on some of the startup costs (options parsing in particular).[ci skip-rust]
[ci skip-build-wheels]