Refactoring JaxbGen to use SimpleCodeGen. #1611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Contains helper method to check generated temp files. | ||
| Mostly just tests that code would be put in the proper package, since that's the easiest point of |
There was a problem hiding this comment.
I don't think this description is very valuable. It will just get out of date as more tests are added.
|
Address my comments as you see fit then feel free to post to RBCommons for a public review. |
1 similar comment
gmalmquist
force-pushed
the
gmalmquist/jaxb-simple-codegen
branch
4 times, most recently
from
b5eb3d6
to
6264772
Compare
|
Changes Unknown when pulling 6264772 on gmalmquist:gmalmquist/jaxb-simple-codegen into * on pantsbuild:master*. |
|
Changes Unknown when pulling 6264772 on gmalmquist:gmalmquist/jaxb-simple-codegen into * on pantsbuild:master*. |
1 similar comment
Also fixed multiple inheritance ordering for wire_gen at pl's recommendation.
gmalmquist
force-pushed
the
gmalmquist/jaxb-simple-codegen
branch
from
6264772
to
5f811a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed multiple inheritance ordering for wire_gen at pl's recommendation.