Add PexRequirements.req_strings_from_requirement_fields()
#16460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added
the
category:internal
benjyw
approved these changes
Aug 9, 2022
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…ld#16460) In several places, we create `PexRequirements` solely to immediately extract out the raw parsed strings. However, we made all call sites unnecessarily deal with `constraint_strings`, which has no impact on the operation. Soon, as part of the per-resolve config project at https://docs.google.com/document/d/1HAvpSNvNAHreFfvTAXavZGka-A3WWvPuH0sMjGUCo48/edit#, we would also likely have made the call sites think about `resolve_name`. Instead, we avoid that confusion. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places, we create
PexRequirementssolely to immediately extract out the raw parsed strings.However, we made all call sites unnecessarily deal with
constraint_strings, which has no impact on the operation. Soon, as part of the per-resolve config project at https://docs.google.com/document/d/1HAvpSNvNAHreFfvTAXavZGka-A3WWvPuH0sMjGUCo48/edit#, we would also likely have made the call sites think aboutresolve_name. Instead, we avoid that confusion.[ci skip-rust]
[ci skip-build-wheels]