Add act to Pants (all in BUILD) and smoke test our workflows
#19278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
added
the
category:internal
cognifloyd
approved these changes
Jun 8, 2023
huonw
approved these changes
Jun 8, 2023
|
Not being able to test locally is one of the main reasons I hate updating our workflows. So yay! |
benjyw
reviewed
Jun 9, 2023
|
|
||
| file( | ||
| name="downloaded-act", | ||
| source=per_platform( |
There was a problem hiding this comment.
This right here is the business!
There was a problem hiding this comment.
I tried doing something similar with GH, but it was sometimes a tar, sometimes not, and just didn't seem worth it at the time.
Maybe I'll try again as well ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is groundwork for/from #19230.
Not only can we have devs run
actnow (without having to install it 😄 (kudos to @chrisjrn 's work in adhoc/shell) but we can smoke test our workflows.My local testing using
acthas actually bore much fruit. Several bugs were caught that existed solely in the YAML file itself. A history of theworkflowsfile shows PRs that mirror my own findings: It's damn hard to test actions. Although this addition represents semi-significant cognitive burden ofactand what goes into smoke testing, I think it's worth it to avoid the large churn that comes with authoring/editing actions. And I want to author more actions (because automation is bae).So, here's the foundation 😄