-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pass-through args to the repl goal for ipython #19858
Conversation
Currently this work for an ipython shell, but does not work for a python shell. I am debugging why this might be. |
Ok, the issue with supplying arguments to the python repl has to do with two separate apparent issues with, upon closer debugging.
It is quite likely one or both of these already has a reported issue in pex, need to dig for them. |
|
Mind editing the title to be a bit more clear as to whats changing? 😄 |
@thejcannon Changed it. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Sorry for the long delayed review.
Fixes #3423
As discussed in #3423 (comment) we are implementing args at the goal-level but with a caveat that it is only available for some shells. In this PR, we only enable it for ipython. The repl will error out otherwise.