Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [junit-security-manager] report security errors on test cases #6203

Conversation

baroquebobcat
Copy link
Contributor

Reports security violations in test environments as test failures instead of in the unexpected exit handler.

TODO create a good summary with examples.

baroquebobcat added a commit to twitter/pants that referenced this pull request Dec 3, 2018
While working on pantsbuild#6203, I moved some things around that were not directly related to that change. These are those bits
@baroquebobcat baroquebobcat force-pushed the nhoward/junit_runner_security_mgr branch 2 times, most recently from 2530455 to 33b7755 Compare December 4, 2018 00:44
baroquebobcat added a commit that referenced this pull request Jan 29, 2019
While working on #6203, I moved some things around that were not directly related to that change. These are those bits.

This flattens some nested ifs and adds some helper fns to create places that #6203 can extend from.
@baroquebobcat baroquebobcat force-pushed the nhoward/junit_runner_security_mgr branch from bd1f43a to b10202f Compare February 25, 2019 17:57
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
…gr' into nhoward/junit_runner_security_mgr

[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]  # No Rust changes made.
@Eric-Arellano
Copy link
Contributor

Closing due to being stale, although this does seem like a neat feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants