Run contrib tests with unit tests and integration tests for fewer CI delays #7709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blorente
approved these changes
May 13, 2019
The contrib folders have these, but we don't want to run them.
Eric-Arellano
changed the title
|
This fails due to running contrib unit tests with |
Eric-Arellano
changed the title
|
Closing in favor of #7845. This solution is now out of sync with master as well. If we wanted to move forward with this approach, we should start by getting chroot to work for contrib. |
Makes for a faster failure if the core integration tests fail
Eric-Arellano
changed the title
Eric-Arellano
commented
Jun 4, 2019
There was a problem hiding this comment.
Now ready for review.
This PR means that the unit tests will take even longer :/ @blorente and I discussed creating our own manual shards for unit tests: one to run V2 and one to run V1 + contrib + ci.sh -l. I punted on that work to do in a followup PR.
| @@ -27,18 +27,9 @@ Usage: $0 (-h|-2fxbkmrjlpuneycitzsw) | |||
| -j run core jvm tests | |||
| -l run internal backends python tests | |||
| -p run core python tests | |||
| -u SHARD_NUMBER/TOTAL_SHARDS | |||
There was a problem hiding this comment.
This should have been removed from #7724.
jsirois
approved these changes
Jun 4, 2019
Eric-Arellano
commented
Jun 5, 2019
jsirois
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The contrib shards consistently are the blocker for CI runs because they appear near the end of the shards.
While discussing options to fix this, we realized that there is no compelling reason for the contrib folder to have its own dedicated shard(s). Instead, it would be valuable to use the split between unit tests vs. integration tests with the contrib code too.
Solution
Merge contrib tests into the unit tests and integration tests shards.
Result
The unit tests and integration tests shards will take slightly longer, but we will no longer be blocked by contrib at the end of the run.