Fix #7895 breaking CI for pull requests #7921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 703338f.
Eric-Arellano
changed the title
blorente
approved these changes
Jun 21, 2019
benjyw
approved these changes
Jun 21, 2019
Eric-Arellano
changed the title
|
Merging without full CI run since this is breaking master. Confirmed it works for both branch build and pull request build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7895 works for branch builds, but not pull request builds due to the error
Partial credentials found in env, missing: AWS_SECRET_ACCESS_KEY.This would happen because we always would define
AWS_SECRET_ACCESS_KEY, but the valueAWS_SECRET_ACCESS_KEYwould only be defined on branch builds because it's encrypted.Instead, we should only define
AWS_SECRET_ACCESS_KEYif we're on a branch build.