Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7895 breaking CI for pull requests #7921

Merged
merged 4 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 21, 2019

#7895 works for branch builds, but not pull request builds due to the error Partial credentials found in env, missing: AWS_SECRET_ACCESS_KEY.

This would happen because we always would define AWS_SECRET_ACCESS_KEY, but the value AWS_SECRET_ACCESS_KEY would only be defined on branch builds because it's encrypted.

Instead, we should only define AWS_SECRET_ACCESS_KEY if we're on a branch build.

@Eric-Arellano Eric-Arellano marked this pull request as ready for review Jun 21, 2019

@Eric-Arellano Eric-Arellano changed the title WIP: Hotfix #7895 breaking CI for pull requests Hotfix #7895 breaking CI for pull requests Jun 21, 2019

@blorente blorente self-requested a review Jun 21, 2019

@blorente
Copy link
Contributor

left a comment

Looks great, thanks for the quick fix!

@benjyw

benjyw approved these changes Jun 21, 2019

@Eric-Arellano Eric-Arellano changed the title Hotfix #7895 breaking CI for pull requests Fix #7895 breaking CI for pull requests Jun 21, 2019

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Merging without full CI run since this is breaking master. Confirmed it works for both branch build and pull request build.

@Eric-Arellano Eric-Arellano merged commit df7ac26 into master Jun 21, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@Eric-Arellano Eric-Arellano deleted the hotfix-aws-sync branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.