Extract cbindgen'd interface into its own crate #8013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested review from
stuhood,
jsirois,
cosmicexplorer,
blorente and
gshuflin
jsirois
approved these changes
Jul 6, 2019
stuhood
approved these changes
Jul 9, 2019
| # We need to parse the engine crate to codegen PyResult (because externs are both something we use | ||
| # from Python in engine, and something we expose to python in engine_cffi). | ||
| # | ||
| # We need to parse the logging crate to codegen PythonLogLevel and Destination. |
There was a problem hiding this comment.
This should mention the list in engine_cffi/build.rs, and vice-versa.
cosmicexplorer
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
I don't have as much time as I'd want to right now to go over this, but I'm extremely excited about this change, and I believe it can close #8009! Thank you so much!
I think ideally I would've moved the engine crate out into a new
subcrate, but this way around better preserves git history and avoids
merge conflicts.
I think I agree with this, but I also feel like separating the ffi interface specifically into a subcrate makes a lot of sense by itself as an incremental step. I'd love to have an interface to other languages at some point.
This means that we compile engine before we try running cbindgen over it, so we get useful parse errors out of rustc, rather than errors manifesting themselves as cbindgen going "There was a parse error somewhere!" I think ideally I would've moved the engine crate out into a new subcrate, but this way around better preserves git history and avoids merge conflicts.
illicitonion
force-pushed
the
dwagnerhall/cbindgen
branch
from
ed24aa2
to
4720f06
Compare
illicitonion
added a commit
that referenced
this pull request
Jul 10, 2019
This means that we compile engine before we try running cbindgen over it, so we get useful parse errors out of rustc, rather than errors manifesting themselves as cbindgen going "There was a parse error somewhere!" I think ideally I would've moved the engine crate out into a new subcrate, but this way around better preserves git history and avoids merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we compile engine before we try running cbindgen over
it, so we get useful parse errors out of rustc, rather than errors
manifesting themselves as cbindgen going "There was a parse error
somewhere!"
I think ideally I would've moved the engine crate out into a new
subcrate, but this way around better preserves git history and avoids
merge conflicts.