Revert "Make precomputing fail more usefully (#7994)" #8024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It introduced failures in the nightly cron (pantsbuild#8023), and a bunch more errors when we tested it on Twitter internal targets.
Eric-Arellano
approved these changes
Jul 8, 2019
stuhood
approved these changes
Jul 9, 2019
|
@stuhood commented on the original issue with a list of the big open issues: #4438 (comment) |
# Delete this line to force a full CI run for documentation-only changes. SKIP_FULL_CI # Documentation-only change.
illicitonion
pushed a commit
that referenced
this pull request
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It introduced failures in the nightly cron (#8023), and a bunch more
errors when we tested it on Twitter internal targets.