Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make precomputing fail more usefully (#7994)" #8024

Merged
merged 2 commits into from Jul 10, 2019

Conversation

@blorente
Copy link
Contributor

commented Jul 8, 2019

It introduced failures in the nightly cron (#8023), and a bunch more
errors when we tested it on Twitter internal targets.

Revert "Make precomputing fail more usefully (#7994)"
It introduced failures in the nightly cron (#8023), and a bunch more
errors when we tested it on Twitter internal targets.
@Eric-Arellano
Copy link
Contributor

left a comment

No need to apologize! This is part of the development process (CS teachers conference is actually talking about that right now!)

Looks good other than removing apology from PR description :)

@stuhood

stuhood approved these changes Jul 9, 2019

Copy link
Member

left a comment

It would be good to revisit discussion of what it would take to enable pantsd by default, which would allow for catching these earlier. It feels like we're very close.

@blorente

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@stuhood commented on the original issue with a list of the big open issues: #4438 (comment)

Empty commit to trigger Travis
# Delete this line to force a full CI run for documentation-only changes.
SKIP_FULL_CI  # Documentation-only change.

@blorente blorente merged commit 5ee10a4 into pantsbuild:master Jul 10, 2019

illicitonion added a commit that referenced this pull request Jul 10, 2019

Revert "Make precomputing fail more usefully (#7994)" (#8024)
It introduced failures in the nightly cron (#8023), and a bunch more
errors when we tested it on Twitter internal targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.