[messages] add AUTOPILOT_VERSION #1050
Conversation
|
@gautierhattenberger @dewagter @esden @martinmm |
|
I don't think it is worth keeping both BOOT and AUTOPILOT_VERSION. We could send only one of them with the fields currently in AUTOPILOT_VERSION. I don't mind the name. |
|
I just thought the BOOT message was still used in some places in the ground or logalizer code, but it seems that is only the case for some long unmaintained matlab logalizer code... |
|
Actually, why do we send the version and SHA since it is already in the string version (and even more) |
|
I added the integer version because that can be easily parsed.... would vote to keep that. |
|
Regarding the format modifiers: is it maybe because the value is But as long as it works with |
|
The formatted_string_of_value is still failing... |
|
@gautierhattenberger @martinmm @dewagter do you see any reason to keep the |
|
Didn't it contain the md5 hash of the used conf? -Christophe On Sun, Dec 21, 2014 at 4:59 PM, Felix Ruess notifications@github.com
|
|
ow sorry, that is the ALIVE message. As long as we keep the MD5, changing boot is fine with me. -Christophe On Sun, Dec 21, 2014 at 7:41 PM, Christophe De Wagter dewagter@gmail.com
|
- always save build version when updating anything that depends on libpprz, so it will also be updated on e.g. make tmtc - only warn if the version number (major.minor.patch) is different, disregard the label, sha1, dirty postfixes in the string...
flixr
force-pushed
the
autopilot_version_msg
branch
from
807dd18
to
6483af3
Compare
[messages] replace BOOT with AUTOPILOT_VERSION The AUTOPILOT_VERSION message contains: - the version encoded as integer with `MAJOR * 10000 + MINOR * 100 + PATCH` - the complete version string as returned by paparazzi_version This message is sent once at startup of the autopilot, but can also be registered like any normal telemetry message by adding it to the telemetry airframe file. The version string is also displayed in the GCS alert window (once per aircraft, unless it changes)... Also the "build version" is not written to `var/build_version.txt` and the server also writes it to the log. When building an aircraft it will now warn if the last build version differs from current version. It only checks if the current version number (e.g. 5.3.2) is contained in the full build version string. So it will warn if you changed branches to a different version, but not after e.g. committing only a airframe config change. You can also run `make print_version` to show the current version (and the warning if build version differs).
|
How often is this message sent? On Mon, Dec 22, 2014 at 8:38 AM, Felix Ruess notifications@github.com
|
|
It is sent once at boot. With 0f0f118 I also added it to some default telemetry modes (sent every 11.1 seconds)... |
|
Great. If it was just at boot it wouldn't be as useful for me
|
Proposal on adding an
AUTOPILOT_VERSIONmessage, see also #1048 for previous discussion on this...Finally merged state:
The AUTOPILOT_VERSION message contains:
MAJOR * 10000 + MINOR * 100 + PATCHThis message is sent once at startup of the autopilot, but can also be registered like any normal telemetry message by adding it to the telemetry airframe file.
The version string is also displayed in the GCS alert window (once per aircraft, unless it changes)...
Also the "build version" is not written to
var/build_version.txtand the server also writes it to the log.When building an aircraft it will now warn if the last build version differs from current version.
It only checks if the current version number (e.g. 5.3.2) is contained in the full build version string. So it will warn if you changed branches to a different version, but not after e.g. committing only a airframe config change.
You can also run
make print_versionto show the current version (and the warning if build version differs).