[vision] Opticflow rewrite #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,6 @@ | |||
| </description> | |||
|
|
|||
| <section name="VISION" prefix="VISION_"> | |||
| <define name="HOVER" value="FALSE" description="TRUE/FALSE active or not"/> | |||
| <define name="PHI_PGAIN" value="500" description="optic flow pgain"/> | |||
| <define name="PHI_IGAIN" value="10" description="optic flow igain"/> | |||
There was a problem hiding this comment.
Error in define.. maybe add more ;)
| // ************************************************************************************* | ||
|
|
||
| // FAST corner detection (TODO: non fixed threashold) | ||
| static uint8_t threshold = 20; |
|
I think this is ok to merge now? |
dewagter
added a commit
that referenced
this pull request
Apr 9, 2015
[vision] Opticflow rewrite: -less grabbing threads -faster grabbing -static linking issues fixed properly -documentation -rewritten code
|
Much better than the version in master: no reason to delay this merge. Make new issue if problems remain. |
|
Can you please fix the dox that is now not correct any more for quite a lot of functions? |
|
Which docs do you mean? I already fixed some mistakes in master.. |
|
Wrong params in function docs, e.g. Lukas kanade...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the optical flow and vision parts for Linux.
This adds a more modular and clean way of adding vision modules and calculations. There is a sample image library which is very well documented and could be expanded in the future.
A lot of improvement to the optical flow calculations could be done, but this is just a simple implementation. In the future we could for example keep track of previous found coners, optimize subpixel calculations etc.
What still needs to be done: