[NPS] add possibility to simulate loss of datalink/downlink #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a bit of a hack, especially we can't disable changing settings if datalink is disabled, since we need to parse that to enable the datalink via settings again. Nevertheless it should suffice for most cases and close #934
|
It is already a good start, I think we can merge. |
gautierhattenberger
added a commit
that referenced
this pull request
Mar 27, 2015
[NPS] add possibility to simulate loss of datalink/downlink close #934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit of a hack, especially we can't disable changing settings if datalink is disabled,
since we need to parse that to enable the datalink via settings again.
Also previously datalink_time was never reset to 0...
Nevertheless it should suffice for most cases and close #934