Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the option to track back flow, adding an error to flow vectors… #2305

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

guidoAI
Copy link
Contributor

@guidoAI guidoAI commented Jul 31, 2018

…, adding the show flow option to the xml and user interface.

…, adding the show flow option to the xml and user interface.
@@ -27,6 +27,7 @@
#include "image.h"
#include <stdlib.h>
#include <string.h>
#include "lucas_kanade.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is a little strange, in principle the image.c/h should not be dependent on a specific optical flow file. That said, I also don't think the image_show_flow should be in this file either as it is specific to optical flow and not generic images. In principle, the draw vector should be here and the image_show_flow should be wherever the flow functions are implemented.

I won't ask you to change this here as you didn't introduce the core problem and I know you don't have time to fix it but consider this in the future.

@kirkscheper
Copy link
Member

If you clean up the indentation and run fix_code_style I will merge this.

@guidoAI
Copy link
Contributor Author

guidoAI commented Aug 13, 2018

Done!

Indeed a good idea to place the show flow somewhere else. Will look at it in the future (time permitting).

@kirkscheper kirkscheper merged commit d1b31a5 into paparazzi:master Aug 14, 2018
biancabndris pushed a commit to biancabndris/paparazzi that referenced this pull request Aug 29, 2018
paparazzi#2305)

* Adding the option to track back flow, adding an error to flow vectors, adding the show flow option to the xml and user interface.

* Fixed code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants