exclude the AOA code if USE_AOA is not defined #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it hurt to have these not excluded if USE_AOA is not defined? but I guess you could somehow switch to aoa pitch mode and not have USE_AOA defined, then the estimator_AOA will not have anything meaningful? How should we do this in general? Too many ifdefs are not nice, but if you don't have the AOA module you don't need this part of the code... |
flixr
added a commit
that referenced
this pull request
Aug 16, 2011
makes sense so you can't accidentally switch to AOA pitch mode while you don't even have an AOA sensor
matteobarbera
added a commit
to matteobarbera/paparazzi
that referenced
this pull request
Feb 17, 2021
* files for PDF exercise * Explicit call to python2 for systems that default to python3 * Description and comments fixes
dewagter
pushed a commit
that referenced
this pull request
Apr 8, 2021
* files for PDF exercise * Explicit call to python2 for systems that default to python3 * Description and comments fixes [flight_plan] remove warning about dummy WP Reformatted indents to 2 spaces Added configs for ps4 gamepads, fixed typos (#68) Update: for flight testing in the CyberZoo Fix color gain in mav_course_exercise.xml airframe (#72) [flight_plan] Re-measured the autoland border. It is not safe to exit the red sqaure so it auto-lands to prevent damage. (#73) [Camera] Vision runs faster is unnecessary frames are not grabbed. (#74)
gautierhattenberger
pushed a commit
that referenced
this pull request
Apr 9, 2021
* files for PDF exercise * Explicit call to python2 for systems that default to python3 * Description and comments fixes [flight_plan] remove warning about dummy WP Reformatted indents to 2 spaces Added configs for ps4 gamepads, fixed typos (#68) Update: for flight testing in the CyberZoo Fix color gain in mav_course_exercise.xml airframe (#72) [flight_plan] Re-measured the autoland border. It is not safe to exit the red sqaure so it auto-lands to prevent damage. (#73) [Camera] Vision runs faster is unnecessary frames are not grabbed. (#74) Co-authored-by: Matteo Barbera <matteo.barbera97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.