Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gps u-center onboard #68

Merged
merged 9 commits into from Oct 7, 2011
Merged

Gps u-center onboard #68

merged 9 commits into from Oct 7, 2011

Conversation

dewagter
Copy link
Member

@dewagter dewagter commented Sep 8, 2011

Attempt to improve GPS_CONFIGURE

-GPS_CONFIGURE did not work anymore (initparam -> setbaud ... etc)
-long-boot-time modules (like the UBX-G5010) fail with GPS_CONFIGURE
-initial baudrate need to be known (which is a cause of trouble while configuring)
-after the baudrate change transmission you can often miss the ACK reply when the reconfiguration of the uart was either just to late or just to early...
-several inifinite while loops make lockup quite easy especially when a config message is sent that is not ACK'ed
-GPS_CONFIGURE was not usefull for configuring new devices. People were referred to U-Center.

therefore a gps_ubx_ucenter module was created that should replace GPS_CONFIGURE
-auto-baudrate on startup
-read device version and adapt the settings (NAV/NAV2/NAV5) accordingly
-possibility to get feedback in GCS (settings file/DEBUG message)
-store too eeprom at the end for initial config of new modules
-periodic instead of event (meaning if the GPS does not listen we can at least try again and not lock up)

Any comments, ideas, information, test results etc are very welcome...

@flixr
Copy link
Member

flixr commented Sep 8, 2011

At a glance it looks very nice, I like that much better than having all this directly in gps_ubx.[ch].
So as far as I can see we can remove the configure stuff from gps_ubx, right?
And we don't need the GPS_CONFIGURE flag anymore...

@dewagter
Copy link
Member Author

dewagter commented Sep 8, 2011

I would have removed GPS_CONFIGURE already but still need to look into this
I2C-GPS stuff...

The I2C-GPS module is not working at present so I presume no-one is using it
at the moment. You have any idea who made/used it?

Also some info from a ublox-expert (someone who has many types and knows the
differences) would be useful to configure everything correctly. Should I
configure the 4G dynamics in fixedwing and 1G in rotorcraft automatically
for instance?

PS: please also note that the ucenter code practically is in a separate file
but is included into the ublox.c file in order to be able to use the
send/receive/protocol/etc without making everything globals... probably not
a good programmers practice?

@gautierhattenberger
Copy link
Member

The GPS-I2C has been made by Pascal to use with neo modules in i2c (in order to free an uart). It was not really working and it was before the new i2c driver. I think it is not too difficult to make it work, but it is not urgent as no one is using it.

@flixr
Copy link
Member

flixr commented Sep 18, 2011

merged into dev 9045c05

@flixr flixr merged commit e3e854d into master Oct 7, 2011
dewagter pushed a commit that referenced this pull request Apr 8, 2021
* files for PDF exercise

* Explicit call to python2 for systems that default to python3

* Description and comments fixes

[flight_plan] remove warning about dummy WP

Reformatted indents to 2 spaces

Added configs for ps4 gamepads, fixed typos (#68)

Update: for flight testing in the CyberZoo

Fix color gain in mav_course_exercise.xml airframe (#72)

[flight_plan] Re-measured the autoland border. It is not safe to exit the red sqaure so it auto-lands to prevent damage. (#73)

[Camera] Vision runs faster is unnecessary frames are not grabbed. (#74)
gautierhattenberger pushed a commit that referenced this pull request Apr 9, 2021
* files for PDF exercise

* Explicit call to python2 for systems that default to python3

* Description and comments fixes

[flight_plan] remove warning about dummy WP

Reformatted indents to 2 spaces

Added configs for ps4 gamepads, fixed typos (#68)

Update: for flight testing in the CyberZoo

Fix color gain in mav_course_exercise.xml airframe (#72)

[flight_plan] Re-measured the autoland border. It is not safe to exit the red sqaure so it auto-lands to prevent damage. (#73)

[Camera] Vision runs faster is unnecessary frames are not grabbed. (#74)

Co-authored-by: Matteo Barbera <matteo.barbera97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants