Air data improvements and conversion to module #853
Conversation
flixr
force-pushed
the
air_data_improvements
branch
from
8b19efe
to
a48093c
Compare
flixr
force-pushed
the
air_data_improvements
branch
from
a48093c
to
b0b2542
Compare
|
@gautierhattenberger what do you think? Good to merge? |
|
I think it is fine to merge, but maybe adding a warning telling to load the module would be nice, at least for some time, what do you think ? |
|
Warning to load the module for which cases? For the fw/rc firmware in general so you can get BARO_RAW? |
|
of course it is not the best to have the warning in the general case, but it can be temporary so people are not surprised to "loose" the BARO_RAW message. |
|
Hm... not a big fan of such a general warning as everyone will get this warning (even if they don't have a baro or never use/need the BARO_RAW message)... I would rather write an email on the mailing list about these changes. But also wondering about the message name: maybe |
|
I guess it is just a few more question on the ML if people miss the email. For the name, it use to be a raw value, but since it is not anymore, I guess we can change it now. |
|
Ok... just add whatever warning you think is best... Regarding the |
flixr
force-pushed
the
air_data_improvements
branch
from
b0b2542
to
6403c95
Compare
|
Added an AIR_DATA message, would actually be in favor of dropping the BARO_RAW message (since it is not raw, you have the sensor specific messages for that, and diff is not used in most cases anyway). |
- removed airspeed_scale - true airspeed (TAS) factor calculated from pressure and temp - if that is not available, tas_factor can be set manually (and could be used to replace airspeed_scale
so you can let it calc the airspeed without pushing it to the state interface, e.g. to use a different airspeed sensor for state interface and hence control
flixr
force-pushed
the
air_data_improvements
branch
from
c4fa867
to
36b9e05
Compare
|
@gautierhattenberger I would also drop the aoa and sideslip, it is not used anyway... I guess we can keep the AIR_DATA name as it is short... although atmospheric data would be a bit more precise. |
|
It is not using aoa and sideslip but it should. I just didn't make it yet, but the AOA module should also publish an ABI message and let air_data update the state interface. It would be consistent with other sensors. About the name itself, on big aircraft, this system is called Air Data Computer, but the name ADC was not an option here ! |
|
@gautierhattenberger ok, sounds good.. |
flixr
force-pushed
the
air_data_improvements
branch
from
e37a57f
to
efa3d84
Compare
|
@gautierhattenberger, unless you want to add something here now, I would merge it as is. |
|
Ok to merge like this. The only thing I can see is to add a binding to an airspeed message, in case a sensor provides directly this value. Since we don't have such thing yet, it is not really urgent... |
|
Actually all airspeed sensor modules currently have the option to directly compute and set the airspeed and e.g. airspeed_ets doesn't output differential pressure and instead only the raw value, offset and airspeed. But still merging this as binding to an airspeed ABI message can still be done later. |
Converts air_data to a module and adds: - math functions for QNH, etc. from #837 - subscribe to BARO_DIFF via ABI - subscribe to TEMPERATURE via ABI - calculate airspeed from differential pressure if enabled (default) - calculate QNH from abs pressure and altitude (enabled by default) - calculate AMSL from baro pressure and QNH (disabled by default) - calculate true airspeed (TAS) from equivalent airspeed (EAS) using a `tas_factor` (with default to 1.0) - calculate `tas_factor` from ISA model and current pressure and temperature (enabled by default) - send new AIR_DATA and AMSL messages
Converts air_data to a module and adds:
tas_factor(with default to 1.0)tas_factorfrom ISA model and current pressure and temperature (enabled by default)I think this is a better place to handle QNH than the qnh.xml module from #837
QNH and TAS not tested in real flight so far...