Feature: Remove requirements.txt and use pipenv everywhere #1316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR removes the requirements.txt file and instead changes the Docker image and CI steps to all use
pipenv
.This is mostly so dependencies are not managed in 2 places and also means dependabot will be more useful, as it no longer updates both requirements.txt and Pipfile.lock.
I compared the release zip and everything matched locations after the changes made to the release steps. These changes where required so pipenv wouldn't need create a .venv twice, for the checked code folder and again for the dist folder.
Finally, to ensure backwards compatibility with all the docs and previous releases, a requirements.txt is still generated and included as part of the release package.
Type of change
Checklist:
pre-commit
hooks, see documentation.