-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes markup issues #391
Open
funkyfuture
wants to merge
11
commits into
papyri:master
Choose a base branch
from
delb-xml:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes markup issues #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as parenthesis aren't valid within NCNAMEs
As there's no abbreviation provided in the context, most likely the fragment was meant to tag an unclear transcription.
As the start of the surrounding lines seem to contain hardly recognizable contents, it's likely that this was meant in the wrongly encoded part as well.
as it was situated before a closing tag. That the following literal was the proper starting position is a plausible guess.
I used the Unicode name for the replaced one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of the fixes targets invalid XML where parenthesis are used as xml:id values. that makes it impossible for strict XML processors to load the affected document.
some Windows OS-based editors seem to been used as one URL ended with a LF entitity which is unexpected and depending on the client code / used URL parser might lead to problems.
there are also several occurances of

(CR) in change records without any semantical significance, certainly stemming from the Windows editor world, and possibly an annoyance for users. let me know if i should amend an removal of these as well.