Fix issues with HTML cache and updates #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will run the clear() function to empty any caches if an attribute has been changed, added, or removed.
1 similar comment
While the Tag test doesn't test this issue, I think it's a good addition. This particular bug/issue isn't triggered until you ask the library to 'render' the html for you. The HtmlTest does infact test this bug and when run on current master it WILL fail; however, it passes with the changes suggested.
1 similar comment
This was referenced Dec 29, 2016
Merged
|
With the newest patch added to the PR this will also address issues in #88 |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #100 and I'll continue looking into issue #99 as well to see if I can fix that too.
I found the issue while working with this library to create a tool I need for work. I wasn't getting the expected output from the outerHtml() function after updating link href's so I needed to dig deeper. After investigating the issue and finding issue #99 I realized they are very similar and related to the same underlying bugs.