Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra initial (blank) message for streaming requests #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove extra initial (blank) message for streaming requests #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faf0329
fix: Remove extra initial (blank) message for streaming requests
gabrielgrant Jun 28, 2017
37b2746
fix: pin upgraded typescript version to fix errors compiling lodash
gabrielgrant Aug 3, 2017
3006e76
fix: upgrade rxjs to 5.4.2 to fix compile error with TS 2.4
gabrielgrant Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"dependencies": {
"lodash": "^4.0.0",
"rxjs": "5.0.0-rc.5"
"rxjs": "5.4.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this to something a bit more liberal, like rxjs at ~5.4.0?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific fix needed was in 5.4.2, so ~5.4.0 won't do, but I believe ~5.4.2 should work. I'll make the change.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this change is good. ~5.4.2, that is.

},
"devDependencies": {
"@types/es6-promise": "0.0.32",
Expand All @@ -41,7 +41,7 @@
"protobufjs": "^5.0.0",
"ts-node": "^1.7.0",
"tslint": "^4.0.0",
"typescript": "^2.1.0"
"typescript": "2.4.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here, I'd prefer ^2.4.0 to 2.4.2 speciically

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a compiler question so it's not actually that critical to do this, I suppose

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I believe there was a breaking change specifically between 2.4.0 and 2.4.1, so I don't think ^2.4.0 is a good idea, but ~2.4.2 should work. That being said, the fact that they introduced a breaking change in a patch release seems like perhaps a good reason to not trust that future patch releases will be problem-free, and given this is the compiler, I'd be a bit more inclined to leave this pegged exactly than with RXJS. I don't have super-strong feelings either way, though. What do you prefer?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to keep it pegged that's fine. I see what you're saying about the breaking changes

},
"config": {
"commitizen": {
Expand Down
4 changes: 0 additions & 4 deletions src/server/call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ export class Call {
this.streamHandle = this.service.stub[camelMethod]((error: any, response: any) => {
this.handleCallCallback(error, response);
});
// If they sent some args (shouldn't happen usually) send it off anyway
if (args) {
this.streamHandle.write(args);
}
} else if (rpcMeta.requestStream && rpcMeta.responseStream) {
this.streamHandle = this.service.stub[camelMethod]();
this.setCallHandlers(this.streamHandle);
Expand Down