Suggestions for build script updates

[simonbengtsson]

The build scripts works great as is, but thought I would suggest a few changes I think would make it more streamlined to contribute to the project. Mostly these are changes that aligns the project with common build scripts I have seen in the javascript/node community.

Practical

• 1. Use semver instead of time based versioning
• 2. Add script that makes it easier to publish new version to npm (would fix Update version in NPM #549)
• 3. Install and use uglifyjs locally instead of globally
• 4. Use npm scripts instead of a makefile
• 5. Use npm to fetch dependencies instead of git submodules

Philosophical

• 6. Remove version property from bower.json EDIT: Already done...
• 7. Rewrite build.sh as a node script
• 8. Use a module bundler to bundle plugins and libs (would hopefully fix Uncaught SyntaxError: Unexpected token ; #506 and Uncaught SyntaxError: Unexpected token ; #684).
• 9. Integrate babeljs to enable es2015 features

I am sure you have thought of many of those things already, but which of these do you think sound like a good idea @MrRio? I have just made similar updates to the jspdf-autotable plugin so it would be fairly straight forward for me to submit pull requests for the proposed changes you like.

[MrRio]

Hi Simon,

Thanks for this.

1. Yep, I agree with this.
2. Yes, this makes sense.
3. That would be a good idea.
4. The build process is a bit of a hangover from the days when you current
   run JS on the commandline (I know right, dinosaur) -- using npm scripts
   make sense.
5. Yep, absolutely. I think these submodules predated npm.
6. Are there any downsides to this? If not, lets go for it.
7. Agreed
8. Yep
9. Hell yeah!

I realise I've just said yes to everything there, haha. Let me know if you
need any help or information.

Cheers,
James

On Fri, 18 Mar 2016 at 14:24 Simon Bengtsson notifications@github.com
wrote:

The build scripts works great as is, but thought I would suggest a few
changes I think would make it more streamlined to contribute to the
project. Mostly these are changes that aligns the project with common build
scripts I have seen in the javascript/node community.

Changes

1. Use semver instead of time based versioning (also would remove
   dependency on python)
2. Add script that makes it easier to publish new version to npm (would
   fix Update version in NPM #549 Update version in NPM #549)
3. Install and use uglifyjs locally instead of globally
4. Use npm scripts https://docs.npmjs.com/misc/scripts instead of a
   makefile
5. Use npm to fetch dependencies instead of using git submodules

Things to consider
6. Removing version property from bower.json (bower can use git tags
instead)
7. Rewriting build.sh as a node script
8. Use a module bundler such as browserify instead of cat/uglifyjs to
bundle plugins
9. Integrate babeljs to enable es6 features

I am sure you have thought of many of those things already, but which of
these do you think sound like a good idea @MrRio
https://github.com/MrRio? I can submit pull requests for the ones you
like.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#713

James Hall
Director
Parallax Agency Ltd
M. 07894950320

[simonbengtsson]

Awesome! I'll see what I can do then! Starting with the easier smaller ones...

[simonbengtsson]

Closing this now since all changes mentioned are implemented in pending PRs. Let me know if there is anything that prevents them from being merged @MrRio. Cheers!