Updated getBlob function to display content in Adobe Acrobat #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Your fix is in the wrong file. I corrected it in the right file. see #1399 |
MrRio
pushed a commit
that referenced
this pull request
Sep 2, 2017
|
@arasabbasi Thanks! |
|
@arasabbasi @MrRio So, which file should I use for development, jspdf.js or jspdf.debug.js? |
|
Depending where the code is. In this case it was basic jspdf functionality which was originally in jspdf.js. So you should have changed it there. If you change something in a library or in a plugin you have to change it there. |
|
@arasabbasi Got it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PDF files generated by the previous version 1.3.4 cannot display some content if opened by Adobe Acrobat, leaving blank instead. The original issue Adobe Acrobat doesn't display all content in the PDF file generated by jsPDF #1316 is described with code.
Solution
Replaced line
1150of jspdf.debug.js,type: "application/pdf", withtype: "data:application/pdf;base64".