Fixed documentation. #2156
Merged
Fixed documentation. #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
requested changes
Dec 18, 2018
src/jspdf.js
Outdated
| * @name setProperties | ||
| * @name setDocumentProperties | ||
| */ | ||
| var setDocumentProperties = API.__private__.setDocumentProperties = API.setProperties = function (properties) { |
There was a problem hiding this comment.
Suggested change
| var setDocumentProperties = API.__private__.setDocumentProperties = API.setProperties = function (properties) { | |
| var setDocumentProperties = API.__private__.setDocumentProperties = API.setProperties = API.setDocumentProperties = function (properties) { |
Well better to add this additional methodname and keep "setProperties" for backwards compatibility
There was a problem hiding this comment.
Hi @arasabbasi , thanks for answering! :-) I totally agree with you. I'm going to do it right now ...
src/jspdf.js
Outdated
| * Sets the LineHeightFactor of proportion. | ||
| * | ||
| * @param {number} value of proportion. default: 1.15 | ||
| * @param {number} value Lineheight value. Default: 1.15. |
There was a problem hiding this comment.
Suggested change
| * @param {number} value Lineheight value. Default: 1.15. | |
| * @param {number} value LineHeightFactor value. Default: 1.15. |
There was a problem hiding this comment.
Indeed. I'm going to send a new PR ...
|
Hi @arasabbasi , applied all suggested changes. :) |
Uzlopak
approved these changes
Dec 19, 2018
|
@silvioprog |
|
Thank you very much @arasabbasi ! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.