Fix issue with CMYK input to encodeColorString #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are fine locally and it's not obvious to me what's failing in the log, any ideas? |
When CMYK input was passed to encodeColorString the values were handled the same as RBG values leading to incorrect colors being set. Now the values are handled correctly by just taking what's passed to the function as per the documentation. Fixes #2274 Also updated decodeColorString to handle CMYK color strings and fixed encodeColorString tests and added some decodeColorString tests
|
The code looks good. Thank you very much. Sometimes the browsers of travis-ci disconnect, resulting in failed tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CMYK input was passed to encodeColorString the values were handled
the same as RBG values leading to incorrect colors being set. Now the
values are handled correctly by just taking what's passed to the
function as per the documentation. Fixes #2274
Also updated decodeColorString to handle CMYK color strings and fixed
encodeColorString tests and added some decodeColorString tests