Work for #3275 #3298
Work for #3275 #3298
Conversation
src/modules/acroform.js
Outdated
| var lastLine = ""; | ||
| var lineCount = 0; | ||
| Line: for (var i in textSplit) { | ||
| Line: for (let i = 0; i < textSplit.length; i++) { |
There was a problem hiding this comment.
Please change let to var. Potentially breaking old JavaScript Engines.
src/modules/acroform.js
Outdated
|
|
||
| for (var x = firstWordInLine; x <= lastWordInLine; x++) { | ||
| line += textSplit[x] + " "; | ||
| const currLine = textSplit[x]; |
There was a problem hiding this comment.
Please change const to var
There was a problem hiding this comment.
That's actually no longer necessary. I've added Babel to the deployment, so you can use modern JS.
| if (formObject.multiline) { | ||
| textSplit = textSplit.map(word => word.split("\n")); | ||
| } else { | ||
| textSplit = textSplit.map(word => [word]); | ||
| } |
There was a problem hiding this comment.
Also, this looks a bit fishy to me. Does this work for a text like "abc \n def"? Wouldn't it be better to split first into lines and then into words?
There was a problem hiding this comment.
Hello, I will add new test soon. Also I reproduced your example and it works:
I think that current solve is easier to implement in your code. In my opinion, your implementation will require more new code than my. So it will be harder to find hypothetical new bugs.
|
Awesome pull request guys, thank you all |
We've fixed this bug