Skip to content

Conversation

srikanth-s2003
Copy link
Contributor

@srikanth-s2003 srikanth-s2003 commented Sep 23, 2025

  • Fixed font face map caching in context2d module
  • Font face map now properly rebuilds when font list changes
  • Resolves issue where custom fonts fail to render after being interrupted by default fonts
  • Maintains performance through intelligent cache invalidation

Fixes #3890

@HackbrettXXX
Copy link
Collaborator

Please add a test case.

- Fixed font face map caching in context2d module
- Font face map now properly rebuilds when font list changes
- Resolves issue where custom fonts fail to render after being interrupted by default fonts
- Maintains performance through intelligent cache invalidation

Fixes parallax#3890
- Added test case to verify font face map cache invalidation
- Test ensures that font changes after adding new fonts work correctly
- Addresses reviewer feedback requesting test coverage
@srikanth-s2003 srikanth-s2003 force-pushed the fix/font-state-management-issue-3890 branch from 314e5c6 to ccc889b Compare October 6, 2025 12:22
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks

@HackbrettXXX HackbrettXXX merged commit 2db3d9d into parallax:master Oct 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html(): Custom font does not get set again if it has already been added once
2 participants