[css] margin not working in html plugin #413 #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this does not fix issue of margin:72ptThe top margin is removed by a call to previous margin in the code. |
There was a problem hiding this comment.
This should have been priorblockstype AKA priorblockstyle. Yes?
Even with this change, code is not working. This method is sometimes called with phantom empty paragraphs that reset the state. Workaround is to use this.priorMarginBottom instead. That may not be best solution however.
There was a problem hiding this comment.
Er, dunno.. i'm not familiar enough with that code, so i'll just assume you're correct, it indeed seems so :)
diegocr
added a commit
that referenced
this pull request
Dec 8, 2014
[css] margin not working in html plugin #413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.