Improve performance in iOS + Phonegap #444
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old way to creating the byte array was causing the iOS + Phonegap implementation of Javascript to run really slow. This change improved performance by orders of magnitude (4x faster for some images).
|
Good to hear! Till now I am still not able to generate and open a PDF either in Android and as well not on iOS devices using Cordova. Could you share a minimalistic implementation or could you give me a short instruction? Thanks in advance! |
|
This PR can be closed, right? |
|
Actually this is the correct PR and #445 what should have been closed :) |
diegocr
added a commit
that referenced
this pull request
Feb 6, 2015
Improve performance in iOS + Phonegap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way to creating the byte array was causing the iOS + Phonegap implementation of Javascript to run really slow. This change improved performance by orders of magnitude (4x faster for some images).