Simplify the standard_fonts_metrics plugin #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phihag
added a commit
to phihag/jsPDF
that referenced
this pull request
Oct 2, 2015
This shaves off a good 1KB from the uncompressed file, and makes it easier to read. Comes with the caveat that addFont has to be called first. Requires parallax#604.
It now runs per font instead of only for addFonts. This allows adding standard fonts later, and simplifies the code by a lot.
phihag
force-pushed
the
fix-simplify-standard-font-metrics
branch
from
e95e0d3 to
8cb8a2a
Compare
MrRio
added a commit
that referenced
this pull request
Feb 29, 2016
Simplify the standard_fonts_metrics plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now runs per font instead of only for addFonts. This allows adding standard fonts later, and simplifies the code by a lot.