Skip to content

Conversation

mohamedasaker-arm
Copy link
Contributor

Signed-off-by: Mohamed Omar Asaker mohamed.omarasaker@arm.com

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
@ionut-arm
Copy link
Member

Changelog?

@mohamedasaker-arm
Copy link
Contributor Author

It will follow after I create the tag on this pr, otherwise, it will be generated with "Unreleased" at the top
and then move the tag.

@ionut-arm
Copy link
Member

You can create the tag now and them remove it after you create the Changelog, otherwise the changelog won't be included in the final tag, right?

@mohamedasaker-arm
Copy link
Contributor Author

no, it will be included, I will move the tag to the commit that includes the changelog
So, If I am not doing it this way. which commit should I put the tag on? if the HEAD, then it will not include bumping crates versions in the change log

@mohamedasaker-arm
Copy link
Contributor Author

Hmm, I think I misunderstood your statement.
I think you want the changelog to have the PR containing the changes of the changelog
Now I wonder how is it possible.
So I am a bit puzzled 😅.

@ionut-arm
Copy link
Member

Ah, no, all I want to make sure is that the final tag covers the changelog as well, regardless of how that's achieved. If you want to push it in a separate PR that's fine by me!

@mohamedasaker-arm
Copy link
Contributor Author

Yes, I will follow this PR with the changelog updates

@ionut-arm ionut-arm merged commit 98a43e7 into parallaxsecond:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants