Skip to content

Conversation

Jakuje
Copy link
Collaborator

@Jakuje Jakuje commented Sep 15, 2025

These functions are not used by rust-cryptoki and not in any release versions so far.

latchset/pkcs11-headers#2

@Jakuje
Copy link
Collaborator Author

Jakuje commented Sep 15, 2025

Used #305 to re-generate the new bindings.

Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but it'd be even better if, instead of "fix another bug" it had at least a single sentence about the bug.

Thanks for the reference I got to the bottom of it :)

These functions are not used by rust-cryptoki and not in any
release versions so far.

latchset/pkcs11-headers#2

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
@Jakuje
Copy link
Collaborator Author

Jakuje commented Sep 16, 2025

The change looks good but it'd be even better if, instead of "fix another bug" it had at least a single sentence about the bug.

Good point! Will improve the commit message :)

@Jakuje Jakuje force-pushed the pkcs11-3.2-wrap-authenticated branch from f293482 to 4bf190b Compare September 16, 2025 07:24
@Jakuje Jakuje changed the title Fix another bug in public domain pkcs11 headers Fix WrapKeyAuthenticated parameter type from pkcs11 header Sep 16, 2025
@Jakuje
Copy link
Collaborator Author

Jakuje commented Sep 16, 2025

Done and rebased.

@hug-dev hug-dev merged commit a7bee1b into parallaxsecond:main Sep 16, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants