Skip to content

Conversation

ionut-arm
Copy link
Member

@ionut-arm ionut-arm commented Jan 13, 2022

Preparing to release new versions of the cryptoki crates.

(The version number of cryptoki had already been changed.)

cc @vkkoskie @ximon18

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good! 🚀

@hug-dev
Copy link
Member

hug-dev commented Jan 13, 2022

Looks good to me! Would be nice if @vkkoskie can give their green light, since they did so many changes and plans for the crate recently

@vkkoskie
Copy link
Contributor

My apologies for being silent so long. I was trying to take "holiday" as seriously as possible and took a break from hobby coding for a while. I have no objections.

Is the plan to publish immediately, or merge #68 first? I'll be responding there next.

@ionut-arm
Copy link
Member Author

My apologies for being silent so long. I was trying to take "holiday" as seriously as possible and took a break from hobby coding for a while. I have no objections.

Is the plan to publish immediately, or merge #68 first? I'll be responding there next.

Happy to see you back! :D

There is no plan - I think it mostly depends on whether you have some personal projects that depend on #68 being in the next release. Otherwise I'd lean towards releasing as-is, since @ximon18 (who requested the release) has already updated some of his crates to work with the tip of main, and I think #68 would mean a lot more changes to deal with :)

@ximon18
Copy link
Contributor

ximon18 commented Jan 14, 2022

I'd be fine with making changes to adapt to the impacts of #68, the issue however is that the lack of a cryptoki release is blocking a very big HSM PR merge in our project that we keep trying to get merged down to our dev branch so that we can continue development. Otherwise new work starts and then the HSM PR branch requires merging again, possibly a lot of work, and we again do another release without the HSM feature. We were ready to merge the PR branch when we found that the pkcs11 crate didn't work at all on ARM7 targets, then we updated to cryptoki which fixes that and everything seems good to go, but we can't release our crate with a git dependency pointing to the tip of cryptoki main, crates.io won't allow it, and we need our dev branch to be potentially releasable, so we really need the cryptoki v0.3.0 release I'm afraid.

@ionut-arm ionut-arm merged commit 3bdaf13 into parallaxsecond:main Jan 14, 2022
@ionut-arm ionut-arm deleted the v-bump branch January 14, 2022 10:16
@ionut-arm
Copy link
Member Author

Okay, I've published 0.3.0 of cryptoki and 0.1.3 of cryptoki-sys.

@vkkoskie - if you'd like #68 into a release ASAP I'm happy to do a 0.4.0 of cryptoki right after the merge.

@vkkoskie
Copy link
Contributor

No rush. I was thinking that having one breaking publication would be better than two from the perspective of having to update client code, but that's clearly not the case here.

@vkkoskie
Copy link
Contributor

@ionut-arm Uh, oh. 😉 It looks like you had 0.4.0 on the mind when you updated the Changelog file for 0.3.0.

@ionut-arm
Copy link
Member Author

@ionut-arm Uh, oh. 😉 It looks like you had 0.4.0 on the mind when you updated the Changelog file for 0.3.0.

oops 😅 Will fix in a future PR! Thanks for noticing!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants