-
Notifications
You must be signed in to change notification settings - Fork 84
Version bump #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump #79
Conversation
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good! 🚀
Looks good to me! Would be nice if @vkkoskie can give their green light, since they did so many changes and plans for the crate recently |
My apologies for being silent so long. I was trying to take "holiday" as seriously as possible and took a break from hobby coding for a while. I have no objections. Is the plan to publish immediately, or merge #68 first? I'll be responding there next. |
Happy to see you back! :D There is no plan - I think it mostly depends on whether you have some personal projects that depend on #68 being in the next release. Otherwise I'd lean towards releasing as-is, since @ximon18 (who requested the release) has already updated some of his crates to work with the tip of |
I'd be fine with making changes to adapt to the impacts of #68, the issue however is that the lack of a |
No rush. I was thinking that having one breaking publication would be better than two from the perspective of having to update client code, but that's clearly not the case here. |
@ionut-arm Uh, oh. 😉 It looks like you had 0.4.0 on the mind when you updated the Changelog file for 0.3.0. |
oops 😅 Will fix in a future PR! Thanks for noticing!! |
Preparing to release new versions of the
cryptoki
crates.(The version number of
cryptoki
had already been changed.)cc @vkkoskie @ximon18