Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the preferred texture format for the swap chain #140

Closed
parasyte opened this issue Feb 28, 2021 · 0 comments · Fixed by #182
Closed

Use the preferred texture format for the swap chain #140

parasyte opened this issue Feb 28, 2021 · 0 comments · Fixed by #182
Labels
enhancement New feature or request

Comments

@parasyte
Copy link
Owner

This is a followup to #134 (comment)

Note from @JMS55:

Default to wgpu::Adapter::get_swap_chain_preferred_format(), and expose the chosen option. I started on this, but I need to put some more thought into it. I forgot that the format you provide your data as to pixels and the format pixels::ScalingRenderer uses aren't necessarily the same. Also needs some thought into how we want this to work in the cases where you're using pixels::ScalingRenderer via pixels::render_with(). It also might require a bit of refactoring. I definitely need to think on this longer.
@parasyte parasyte added the enhancement New feature or request label Feb 28, 2021
parasyte added a commit that referenced this issue Jun 27, 2021
@parasyte
Use the swapchain-preferred texture format by default
3010a74 
- Fixes #140
- Adds a public method to get the current GPU framebuffer texture format
  (AKA the render texture format).
- This wasn't as difficult as it seemed; the extra API is used by the
  examples to get the right texture format instead of being hardcoded.
@parasyte parasyte mentioned this issue Jun 27, 2021
Merged
parasyte added a commit that referenced this issue Jul 17, 2021
@parasyte
Use the swapchain-preferred texture format by default (#182)
288da36 
- Fixes #140
- Adds a public method to get the current GPU framebuffer texture format (AKA the render texture format).
- This wasn't as difficult as it seemed; the extra API is used by the examples to get the right texture format instead of being hardcoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the swapchain-preferred texture format by default parasyte/pixels
1 participant
@parasyte