Skip to content

Conversation

smiasojed
Copy link
Contributor

@smiasojed smiasojed commented Nov 25, 2024

@smiasojed smiasojed requested review from Jan-Jan and athei and removed request for Jan-Jan November 25, 2024 11:47
@athei
Copy link
Member

athei commented Nov 25, 2024

I think we should remove the quick dapp and just use REMIX to show how to compile a contract. But not how to build a Dapp.

Because right now it is confusing because we show people two different ways to create a Dapp. We should prepare a template repository that people can clone to follow the ether.js part that sets them up with a basic Dapp.

@smiasojed
Copy link
Contributor Author

I think we should remove the quick dapp and just use REMIX to show how to compile a contract. But not how to build a Dapp.

I can remove this, but this PR is more about what to do with the local development section

Because right now it is confusing because we show people two different ways to create a Dapp. We should prepare a template repository that people can clone to follow the ether.js part that sets them up with a basic Dapp.

REMIX supports workspaces from GitHub repository or Gist, which allows us to use them as the default workspace for tutorial

@athei
Copy link
Member

athei commented Nov 25, 2024

Yes the part about local contract development is good. I just don't want to cover frontend development here.

@smiasojed
Copy link
Contributor Author

Yes the part about local contract development is good. I just don't want to cover frontend development here.

I think that local development could be moved outside the tutorial. If we plan to work on template repo, REMIX should probably clone workspace directly from it.

The content which is not needed for the tutorial like quick dapp or local development could be moved to separate page or deleted if we do not see a value there.

@athei
Copy link
Member

athei commented Nov 25, 2024

The point is to guide people to a workflow to iterate on their contract and frontend. Having the contract in the local file system would be good for that, right? I don't expect people to be keen on editing code inside the browser.

REMIX should probably clone workspace directly from it.

That repo would be concerned with building the frontend. And I don't want to conflate REMIX with frontend development.

@smiasojed
Copy link
Contributor Author

smiasojed commented Nov 25, 2024

OK, in this case, we need to start the tutorial by cloning the template repository and connecting to the local filesystem from REMIX.

The drawback is that you need to install REMIXD on your local machine, which is something we wanted to avoid in the beginning.

@smiasojed
Copy link
Contributor Author

As discussed, we will keep only the basics in the Remix tutorial, without covering DApp deployment or development on the local filesystem.

Comment on lines 43 to 45
Note that switching to a local filesystem will cause all previously deployed contracts, both pinned and unpinned, to become invisible in the **Deploy & Run** tab. If you need to interact with already deployed contracts, make sure to note down their addresses beforehand so you can load them later using the **At Address** button.

![Load contract](img/load_contract.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this in the main tutorial. Telling people how to interact with pre-existing contracts is basic knowledge. Just as a separate main heading "## How to interact with already deployed contracts".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kianenigma
Copy link
Collaborator

kianenigma commented Nov 27, 2024

I think we should remove the quick dapp and just use REMIX to show how to compile a contract. But not how to build a Dapp.

As discussed, we will keep only the basics in the Remix tutorial, without covering DApp deployment or development on the local filesystem.

Came to a similar opinion about both via #27.

@smiasojed smiasojed requested a review from athei November 27, 2024 19:27
@athei athei merged commit 2ca25e0 into master Nov 28, 2024
3 checks passed
@athei athei deleted the sm/remixd branch November 28, 2024 09:01
@athei athei mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition to REMIXD confusing
3 participants