listener: Ensure tcp/websocket do not terminate on listener errors #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
| return Poll::Ready(Some(Ok((stream, address)))); | ||
| } | ||
| Poll::Ready(Err(error)) => match error.kind() { | ||
| ErrorKind::ConnectionAborted | ErrorKind::ConnectionReset => { |
There was a problem hiding this comment.
I would double check that socket.accept() can't generate these errors continuously after a socket error — otherwise we would end up busy-looping here.
| ?error, | ||
| "Fatal error for listener", | ||
| ); | ||
| self.listeners[current] = None; |
There was a problem hiding this comment.
IMO a better way would be to terminate the process and let the restarted process listen again, than stopping accepting incoming connections completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that both TCP and WebSocket transports do not terminate in case of listener errors.
Recoverable errors like
ConnectionAborted(which signals that the client connection entered the queue and disconnected before we got a chance to process it) are retried.Nonrecoverable errors lead to the
TokioListenerbeing dropped and never polled again (ie, removed from the transport service).TCP and Websocket are now robust wrt listener errors and will not terminate the main execution loop unless the listeners return None.
Closes: #437
cc @paritytech/networking