Adjust the location of the signer snippet #4155
Conversation
|
Changes Unknown when pulling edc0674 on ng-move-signer into ** on master**. |
|
Keep the related https://github.com/ethcore/parity/issues/3941 in mind. Would prefer on-ice until the above is in since this approach causes some issues with a larger & needed expansion. Think the approach is over-the-top atm (although nice), the dapp being to specify position in the manifest (top-left, top-right, bottom-left, bottom-right) would have been sufficient and consistent. The reality is that for one specific dapp it would need to be dragged and then back again in others. (As to not overlap with the UI - so users would need to repeat each time they swap between affected and non-affected apps) |
|
agree with jaco here; that said, it might be nice to explore how this functionality could work with the dapp-specified position. |
|
We could also save the location per dapp in local storage |
|
yeah; can we alter this to allow the dapp to specify a default position? |
|
@gavofyork Ok so now the position of the Parity Bar is saved in local storage per dapp ; and each dapp can have a default position within |
|
conflicts.. |
|
Changes Unknown when pulling 263548b on ng-move-signer into ** on master**. |
| instance = new DappsStore(api); | ||
| } | ||
|
|
||
| if (api && !instance._api) { |
There was a problem hiding this comment.
Not sure why we are doing this - when we create it we should properly pass in the api. (There is one in the app, no reason why it cannot be passed in)
|
I'm honestly still not even close to on-board with the manual moving. It really is going to create issues for the next phase where the expanded ParityBar moves to a larger Portal (either opened from top/bottom depending on where base is located.) It does work with the current small expanded view, but cannot see how to do things properly when the bar is moved to the middle, unless it is just ignored. Lots of code to move stuff around that adds maintenance complexity as well and I don't see how it really adds value to the end-user apart from "cool to have". On the plus side, do think the per-dapp specification as it is now implemented works really well. |
|
Well it doesn't really get it the middle : the expanded signer can be in four position (computed automatically based on the small parity bar) : NE / NW / SE / SW Regarding migrating to Portal, I don't think that's really an issue. The part of the code that will get modified is the expanded view, which hasn't been touched. As everything is already written, I don't think it would add any more work to port the Signer to the Portal view (compared with porting to the Portal view from current master) |
|
As spoken with @jacogr , the Parity Bar now sticks to only one of the four corners of the screen. |
gavofyork
added
A8-looksgood 🦄
* s/Delete Contract/Forget Contract/ (#4237) * Adjust the location of the signer snippet (#4155) * Additional building-block UI components (#4239) * Currency WIP * Expand tests * Pass className * Add QrCode * Export new components in ~/ui * s/this.props.netSymbol/netSymbol/ * Fix import case * ui/SectionList component (#4292) * array chunking utility * add SectionList component * Add TODOs to indicate possible future work * Add missing overlay style (as used in dapps at present) * Add a Playground for the UI Components (#4301) * Playground // WIP * Linting * Add Examples with code * CSS Linting * Linting * Add Connected Currency Symbol * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * 2015-2017 * Added `renderSymbol` tests * PR grumbles * Add Eth and Btc QRCode examples * 2015-2017 * Add tests for playground * Fixing tests * Split Dapp icon into ui/DappIcon (#4308) * Add QrCode & Copy to ShapeShift (#4322) * Extract CopyIcon to ~/ui/Icons * Add copy & QrCode address * Default size 4 * Add bitcoin: link * use protocol links applicable to coin exchanged * Remove .only * Display QrCode for accounts, addresses & contracts (#4329) * Allow Portal to be used as top-level modal (#4338) * Portal * Allow Portal to be used in as both top-level and popover * modal/popover variable naming * export Portal in ~/ui * Properly handle optional onKeyDown * Add simple Playground Example * Add proper event listener to Portal (#4359) * Display AccountCard name via IdentityName (#4235) * Fix signing (#4363) * Dapp Account Selection & Defaults (#4355) * Add parity_defaultAccount RPC (with subscription) (#4383) * Default Account selector in Signer overlay (#4375) * Typo, fixes #4271 (#4391) * Fix ParityBar account selection overflows (#4405) * Available Dapp selection alignment with Permissions (Portal) (#4374) * registry dapp: make lookup use lower case (#4409) * Dapps use defaultAccount instead of own selectors (#4386) * Poll for defaultAccount to update dapp & overlay subscriptions (#4417) * Poll for defaultAccount (Fixes #4413) * Fix nextTimeout on catch * Store timers * Re-enable default updates on change detection * Add block & timestamp conditions to Signer (#4411) * Extension installation overlay (#4423) * Extension installation overlay * Pr gumbles * Spelling * Update Chrome URL * Fix for non-included jsonrpc * Extend Portal component (as per Modal) #4392
Closes #3867
Add a small button on the signer tab to drag it. The signer opens accordingly to the position.