Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ui/SectionList component #4292

Merged
merged 4 commits into from
Jan 25, 2017
Merged

ui/SectionList component #4292

merged 4 commits into from
Jan 25, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 24, 2017

Renders an array of items into rows of 3 elements each, where :hover allows for an expanded view either by showing or hiding certain elements.

  • Split from https://github.com/ethcore/parity/pull/4284 to allow use in https://github.com/ethcore/parity/pull/4178 without cross-PR dependencies
  • Adds the ui/SectionList component (used in the noted PR to render Accounts, Addresses, Contracts & Dapps)
  • Adds utils/array for array chunking into sizes as passed through, i.e. chunkArray([1, 2, 3, 4], 2) -> [[1, 2], [3, 4]] (used by SectionList component)
  • Additional benefit of making the component PR stand-alone, even in the initial form

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 24, 2017
@ngotchac
Copy link
Contributor

Looks good as a first step. I'm not really convinced about the data-hover="show|hide" but can't really think on a better idea right now. The height animation could be more smooth if we had better control over it.

@ngotchac ngotchac added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 25, 2017
@jacogr
Copy link
Contributor Author

jacogr commented Jan 25, 2017

@ngotchac Agreed on data-hover - think there must be a better way of conveying the same information to the children, what it is escapes me at the moment.

@jacogr jacogr merged commit 380c077 into master Jan 25, 2017
@jacogr jacogr deleted the jg-ui-sectionlist branch January 25, 2017 11:16
jacogr added a commit that referenced this pull request Feb 3, 2017
* array chunking utility

* add SectionList component

* Add TODOs to indicate possible future work

* Add missing overlay style (as used in dapps at present)
jacogr added a commit that referenced this pull request Feb 3, 2017
* array chunking utility

* add SectionList component

* Add TODOs to indicate possible future work

* Add missing overlay style (as used in dapps at present)
gavofyork pushed a commit that referenced this pull request Feb 4, 2017
* s/Delete Contract/Forget Contract/ (#4237)

* Adjust the location of the signer snippet (#4155)

* Additional building-block UI components (#4239)

* Currency WIP

* Expand tests

* Pass className

* Add QrCode

* Export new components in ~/ui

* s/this.props.netSymbol/netSymbol/

* Fix import case

* ui/SectionList component (#4292)

* array chunking utility

* add SectionList component

* Add TODOs to indicate possible future work

* Add missing overlay style (as used in dapps at present)

* Add a Playground for the UI Components (#4301)

* Playground // WIP

* Linting

* Add Examples with code

* CSS Linting

* Linting

* Add Connected Currency Symbol

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* 2015-2017

* Added `renderSymbol` tests

* PR grumbles

* Add Eth and Btc QRCode examples

* 2015-2017

* Add tests for playground

* Fixing tests

* Split Dapp icon into ui/DappIcon (#4308)

* Add QrCode & Copy to ShapeShift (#4322)

* Extract CopyIcon to ~/ui/Icons

* Add copy & QrCode address

* Default size 4

* Add bitcoin: link

* use protocol links applicable to coin exchanged

* Remove .only

* Display QrCode for accounts, addresses & contracts (#4329)

* Allow Portal to be used as top-level modal (#4338)

* Portal

* Allow Portal to be used in as both top-level and popover

* modal/popover variable naming

* export Portal in ~/ui

* Properly handle optional onKeyDown

* Add simple Playground Example

* Add proper event listener to Portal (#4359)

* Display AccountCard name via IdentityName (#4235)

* Fix signing (#4363)

* Dapp Account Selection & Defaults (#4355)

* Add parity_defaultAccount RPC (with subscription) (#4383)

* Default Account selector in Signer overlay (#4375)

* Typo, fixes #4271 (#4391)

* Fix ParityBar account selection overflows (#4405)

* Available Dapp selection alignment with Permissions (Portal) (#4374)

* registry dapp: make lookup use lower case (#4409)

* Dapps use defaultAccount instead of own selectors (#4386)

* Poll for defaultAccount to update dapp & overlay subscriptions (#4417)

* Poll for defaultAccount (Fixes #4413)

* Fix nextTimeout on catch

* Store timers

* Re-enable default updates on change detection

* Add block & timestamp conditions to Signer (#4411)

* Extension installation overlay (#4423)

* Extension installation overlay

* Pr gumbles

* Spelling

* Update Chrome URL

* Fix for non-included jsonrpc

* Extend Portal component (as per Modal) #4392
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants