Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add force remove vesting #1982

Merged
merged 62 commits into from
Nov 6, 2023
Merged

Add force remove vesting #1982

merged 62 commits into from
Nov 6, 2023

Conversation

0xmovses
Copy link
Contributor

@0xmovses 0xmovses commented Oct 23, 2023 •
edited
Loading

This PR exposes a force_remove_vesting through a ROOT call.
See linked issue

@0xmovses 0xmovses requested review from a team October 23, 2023 10:14
@0xmovses 0xmovses marked this pull request as draft October 23, 2023 10:20
@0xmovses 0xmovses changed the title Force remove vesting Add force remove vesting Oct 23, 2023
@0xmovses 0xmovses marked this pull request as ready for review October 23, 2023 10:30
@0xmovses 0xmovses marked this pull request as draft October 23, 2023 10:36
georgepisaltu
georgepisaltu reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@georgepisaltu georgepisaltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, I didn't check the UT yet, will do so later.

substrate/frame/vesting/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/vesting/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/vesting/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/vesting/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/generator/double_map.rs Outdated Show resolved Hide resolved
0xmovses and others added 6 commits October 26, 2023 14:08
@0xmovses
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_vesting

@command-bot
Copy link

command-bot bot commented Oct 29, 2023 •
edited
Loading

@0xmovses https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117744 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_vesting. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 31-63f06407-61aa-4118-85cb-641b2c9ddcaa to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 29, 2023

@0xmovses Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_vesting has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117744 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117744/artifacts/download.

@0xmovses
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 29, 2023 •
edited
Loading

@0xmovses https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117880 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 32-e701dcb2-9dea-4e3e-8281-00c539e8fded to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 29, 2023

@0xmovses Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117880 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117880/artifacts/download.

@0xmovses 0xmovses added the T2-pallets This PR/Issue is related to a particular pallet. label Oct 30, 2023
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 10, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
41cdef1
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 10, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
15f52c0
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 11, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
b436482
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 12, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
e4e017f
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 12, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
b107b08
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 22, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
4998386
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 23, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
045deca
claravanstaden pushed a commit to Snowfork/runtimes that referenced this pull request Feb 5, 2024
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
1d7e42d
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@gupnik gupnik mentioned this pull request Feb 22, 2024
Closed
4 tasks
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@0xmovses @georgepisaltu @seadanda
Add force remove vesting (paritytech#1982)
878ed73 
This PR exposes a `force_remove_vesting` through a ROOT call. 
See linked
[issue](paritytech#269)

---------

Co-authored-by: georgepisaltu <52418509+georgepisaltu@users.noreply.github.com>
Co-authored-by: command-bot <>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@svyatonik
Kusama <> Polkadot relay prototype (paritytech#1982)
28cf5c9 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@svyatonik
Kusama <> Polkadot relay prototype (paritytech#1982)
12baac9 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik
Kusama <> Polkadot relay prototype (paritytech#1982)
9f1cd40 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
d2f000a 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
0191e05 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
acd2a0e 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
da65562 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
322a143 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
8dc4939 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
2c128c7 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
5f61f4e 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
f608a4f 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
6d4e78d 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
61c83ed 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
Kusama <> Polkadot relay prototype (paritytech#1982)
25fbfda 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Kusama <> Polkadot relay prototype (#1982)
9b57f21 
* moved bridge declarations to dedicated folder

* Kusama <> Polkadot bridges declaration

* support for Kusama <> Polkadot bridge in CLI

* update dictionary
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seadanda seadanda seadanda approved these changes

@georgepisaltu georgepisaltu georgepisaltu approved these changes

@juangirini juangirini juangirini approved these changes

Assignees

@0xmovses 0xmovses

Labels
I5-enhancement An additional feature request. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmovses @juangirini @seadanda @georgepisaltu