Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Optimize erasure-coding marshalling #88

Closed
rphmeier opened this issue Jan 18, 2019 · 0 comments · Fixed by #143
Closed

Optimize erasure-coding marshalling #88

rphmeier opened this issue Jan 18, 2019 · 0 comments · Fixed by #143
Labels
I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Jan 18, 2019

In the polkadot-erasure-coding crate (see #56), we split up a bunch of encoded data into byte chunks. Each chunk has the "actual length" prepended to it. This is a bit of a waste, so it should be optimized.

When done, this will need a notification of @drskalman to make sure the specification matches.

@rphmeier rphmeier added I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. Q2-easy labels Jan 18, 2019
@rphmeier rphmeier added this to the PoC-5, 6, 7 milestone Jan 18, 2019
imstar15 pushed a commit to imstar15/polkadot that referenced this issue Aug 25, 2021
* fix test collator compilation failure

Closes paritytech#88.

* copy method instead of using feature

Using a feature gate like "test-features" is problematic because
it is leaky: depending on situational considitons such as the
current working directory when compilation is attempted, the
feature may or may not be applied, which makes success inconsistent.
It's simpler in this case to copy a dozen lines of code than to
work out all the issues with test features.
imstar15 pushed a commit to imstar15/polkadot that referenced this issue Aug 25, 2021
* fix test collator compilation failure

Closes paritytech#88.

* copy method instead of using feature

Using a feature gate like "test-features" is problematic because
it is leaky: depending on situational considitons such as the
current working directory when compilation is attempted, the
feature may or may not be applied, which makes success inconsistent.
It's simpler in this case to copy a dozen lines of code than to
work out all the issues with test features.

* docker script shoudld work on cumulus-branch (default)

* Add storage_append to runtime

Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant