This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Create a more rigid overseer builder pattern that fails at compile time #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
added
A3-in_progress
vstakhov
added
the
B0-silent
drahnr
suggested changes
Jan 20, 2022
drahnr
reviewed
Jan 21, 2022
`subsyste_ctx_name` actually masked `subsystem_ctx_name` and it seems that only the former one is really needed
This is used to pretty format placeholder types names
drahnr
reviewed
Jan 27, 2022
drahnr
reviewed
Jan 27, 2022
drahnr
reviewed
Jan 27, 2022
drahnr
reviewed
Jan 27, 2022
| )* | ||
| }; | ||
| quote! { | ||
| impl <InitStateSpawner, #additional_baggage_generic #( #subsystem_passthrough_state_generics, )* #( #impl_baggage_state_generics, )* > |
drahnr
reviewed
Jan 27, 2022
drahnr
reviewed
Jan 27, 2022
drahnr
reviewed
Jan 27, 2022
Comment on lines
+516
to
518
| let subsystem_string = String::from(stringify!(#subsystem_name)); | ||
| // Convert owned `snake case` string to a `kebab case` static str. | ||
| let subsystem_static_str = Box::leak(subsystem_string.replace("_", "-").into_boxed_str()); |
There was a problem hiding this comment.
note to myself: this could be extracted as generated &'static str rather than the adhoc string generation and leaking it.
drahnr
approved these changes
Jan 27, 2022
drahnr
removed request for
tomusdrw,
svyatonik,
acatangiu and
antonio-dropulic
13 tasks
ordian
added
the
T4-parachains_engineering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests addresses #3772
The general idea is to generalise all fields arguments and fix them in two states:
Uninit<T>for uninitialised fieldsInit<T>for initialised fieldsWith this approach, each setter function accepts builder template with
Uninit<Field>and returns a builder where this field is changed toInit<Field>. Subsequentlybuildfunction accepts all templated fields to beInit<T>and fails to compile if any of the required fields is missing.