This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix incomplete sorting. #4795
Merged
Fix incomplete sorting. #4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
added
A0-please_review
drahnr
reviewed
Jan 27, 2022
runtime/parachains/src/disputes.rs
Outdated
| (Some(a_height), Some(b_height)) => { | ||
| let height_ord = a_height.cmp(&b_height); | ||
| if height_ord == Ordering::Equal { | ||
| a.candidate_hash.cmp(&b.candidate_hash) |
drahnr
approved these changes
Jan 27, 2022
eskimor
force-pushed
the
rk-fix-sorting
branch
from
efabe96
to
53b8280
Compare
bkchr
reviewed
Jan 27, 2022
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
jakoblell
added
D1-audited 👍
ordian
approved these changes
Jan 27, 2022
| if check_equal(previous, current) { | ||
| return true | ||
| } | ||
| previous = current; |
There was a problem hiding this comment.
Personally preferred the previous functional-style impl with windows(2). But this one is also readable, so no complaints.
There was a problem hiding this comment.
I actually prefer this one, it has no unreachable! or implicit unreachable, it's imho cleaner, yet a tad less idiomatic.
Closed
|
bot merge |
ordian
added a commit
that referenced
this pull request
Jan 27, 2022
* master: Fix incomplete sorting. (#4795) Companion for better way to resolve `Phase::Emergency` via governance #10663 (#4757) Refactor and fix usage of `get_session_index()` and `get_session_info_by_index()` (#4735) `relay chain selection` and `dispute-coordinator` fixes and improvements (#4752) Fix tests (#4787) log concluded disputes (#4785) availability-distribution: look for leaf ancestors within the same session (#4596) Companion for Use proper bounded vector type for nominations #10601 (#4709) Fix release profile (#4778) [ci] remove publish-s3-release (#4779) Companion for substrate#10632 (#4689) [ci] pipeline chores (#4775) New changelog scripts (#4491)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.