Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

allow overseer to be enabled anyways #4840

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Feb 3, 2022

Ref #4763

CC @bkchr

If this deviates from your expectation of behavior, then let's schedule a talk.

Assumption here was, we are not running disputes coordinator and as such we want to follow the longest chain as relay chain selection algorithm would do. A keystore most be present for the overseer to launch.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 3, 2022
@drahnr drahnr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 7, 2022
@drahnr drahnr self-assigned this Feb 7, 2022
@drahnr drahnr requested a review from bkchr February 7, 2022 09:15
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had already seen it, but had forgotten to review it :D

@bkchr bkchr merged commit c81bd36 into master Feb 7, 2022
@bkchr bkchr deleted the bernhard-enable-overseer-anyways branch February 7, 2022 09:46
@bkchr
Copy link
Member

bkchr commented Feb 7, 2022

Ahh and thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants