This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Try to fix disputes test #4988
Merged
Try to fix disputes test #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A2-insubstantial
ordian
approved these changes
Feb 25, 2022
| @@ -13,7 +13,7 @@ name = "malus" | |||
| path = "src/malus.rs" | |||
|
|
|||
| [dependencies] | |||
| polkadot-cli = { path = "../../cli", default-features = false, features = ["cli", "malus", "polkadot-native"] } | |||
| polkadot-cli = { path = "../../cli", features = [ "malus", "rococo-native", "kusama-native", "westend-native", "polkadot-native" ] } | |||
There was a problem hiding this comment.
AFAIK, we're only using rococo-local and wococo-local in zombienet tests
cc @pepoviola please correct me if I'm wrong
There was a problem hiding this comment.
AFAIK, we're only using rococo-local and wococo-local in zombienet tests cc @pepoviola please correct me if I'm wrong
Yes, at the moment we are using only those two.
There was a problem hiding this comment.
Suggested change
| polkadot-cli = { path = "../../cli", features = [ "malus", "rococo-native", "kusama-native", "westend-native", "polkadot-native" ] } | |
| polkadot-cli = { path = "../../cli", features = [ "malus", "rococo-native", "polkadot-native" ] } |
There was a problem hiding this comment.
As errors are not propagated in zombienet, I would not do this. Before switching to edition 2021 we also compiled with the exact same set of features.
drahnr
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4987