Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix priority thresholds #5375

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fix priority thresholds #5375

merged 1 commit into from
Apr 22, 2022

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Apr 22, 2022

This PR fix the threshold for Medium prio.

@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 22, 2022
@chevdor chevdor requested review from bkchr and coderobe April 22, 2022 09:53
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test for these perhaps?

@chevdor
Copy link
Contributor Author

chevdor commented Apr 22, 2022

@dvdplm how do you imagine such as test ?

@dvdplm
Copy link
Contributor

dvdplm commented Apr 22, 2022

@dvdplm how do you imagine such as test ?

Yeah good question. Would it be possible to use past releases (whose PRs likely don't change labels) and assert that the priorities assigned are what we expect?

@chevdor
Copy link
Contributor Author

chevdor commented Apr 22, 2022

I would not assume that the past was correct :)
What could be done is to create one or more synthetic context.json(this is where the data about the priorities and labels is located) then generated the release notes and compare with our expectations.

The templates are rather split so we could check each part individually.

@chevdor chevdor merged commit 4c1dcfd into master Apr 22, 2022
@chevdor chevdor deleted the wk-fix-release-notes-prio branch April 22, 2022 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants